[PATCH 2/3] Convert PowerPC MPC i2c to of_platform_driver from platform_driver

Jon Smirl jonsmirl at gmail.com
Thu Jan 24 01:40:38 EST 2008

On 1/23/08, Jon Loeliger <jdl at jdl.com> wrote:
> So, like, the other day Jon Smirl mumbled:
> > Convert MPC i2c driver from a platform_driver to a
> > of_platform_driver. Add the ability to dynamically load i2c drivers
> > based on device tree names. Routine names were changed from fsl_ to
> > mpc_ to make them match the file name. Common code moved to
> > powerpc-common.* Orginal ppc driver left intact for deletion when ppc
> > arch is removed.
> This seems backwards to me.  I was under the impression
> that our trend was _toward_ "Freescale" and "fsl" names...?
> And aren't the drivers also already using "fsl-i2c" in the
> DTS files as called out in the b-w-o.txt too?

The routine names should match the file name which then determines the
module name. I didn't want to change the module name so I made the
routines names match the module name.

> Grumble long lines not hard-limited to 70-ish columns,
> yes, even in log messages... :-)
> jdl

Jon Smirl
jonsmirl at gmail.com

More information about the Linuxppc-dev mailing list