[PATCH 2/3] Convert PowerPC MPC i2c to of_platform_driver from platform_driver

Stephen Rothwell sfr at canb.auug.org.au
Wed Jan 23 14:11:21 EST 2008

On Tue, 22 Jan 2008 21:09:14 -0500 Jon Smirl <jonsmirl at gmail.com> wrote:
> +static struct of_device_id mpc_i2c_of_match[] = {

(sfr winds up his broken record :-))  const, please.

> +#else
> +
>  static int fsl_i2c_probe(struct platform_device *pdev)

While this code is still here, you should still explicitly include

> -      fail_add:
> +fail_add:

If you are going to move labels, many people leave a single space in
front of them so that "diff -p" picks up the function name instead of the
label name.

> +void of_register_i2c_devices(struct i2c_adapter *adap, struct device_node *adap_node)

> +		compatible = of_get_property(node, "compatible", &len);

You can specify NULL instead of &len since you don't use the returned value.

> +		if (!compatible) {
> +			printk(KERN_ERR "i2c-mpc.c: invalid entry, missing compatible attribute\n");

Some of these printk lines are a bit long.

Stephen Rothwell                    sfr at canb.auug.org.au
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20080123/2e698184/attachment.pgp>

More information about the Linuxppc-dev mailing list