[PATCH 2/3 v3] Add initial iomega StorCenter board port.

[Stephen Rothwell]

Hi Jon,

On Tue, 22 Jan 2008 16:37:59 -0600 Jon Loeliger <jdl at jdl.com> wrote:
>
> +++ b/arch/powerpc/platforms/embedded6xx/storcenter.c

> +extern void _nmask_and_or_msr(unsigned long nmask, unsigned long or_val);

This clearly needs to be decalred in some header file.  (I know you did
not introduce it.)  In arch/ppc, it was declared in asm/system.h (but I
don't know if that is appropriate for arch/powerpc).  Maybe you could do
a preceeding patch that does this and fixes the other user.

> +static void __init storcenter_init_IRQ(void)
> +{
> +	struct mpic *mpic;
> +	struct device_node *dnp;
> +	const void *prop;
> +	int size;
> +	phys_addr_t paddr;
> +
> +	dnp = of_find_node_by_type(NULL, "open-pic");
> +	if (dnp == NULL)
> +		return;
> +
> +	prop = of_get_property(dnp, "reg", &size);
> +	paddr = (phys_addr_t)of_translate_address(dnp, prop);

What happens of "prop" is NULL?

-- 
Cheers,
Stephen Rothwell                    sfr at canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20080123/31aa09fd/attachment.pgp>