[PATCH] [POWERPC]: constify function pointer tables

Stephen Rothwell sfr at canb.auug.org.au
Wed Jan 23 10:11:18 EST 2008


Hi Jan,

Good idea ... but ...

On Tue, 22 Jan 2008 20:43:09 +0100 (CET) Jan Engelhardt <jengelh at computergmbh.de> wrote:
>
> diff --git a/arch/powerpc/kernel/setup-common.c b/arch/powerpc/kernel/setup-common.c
> index 2de00f8..57d4f28 100644
> --- a/arch/powerpc/kernel/setup-common.c
> +++ b/arch/powerpc/kernel/setup-common.c
> @@ -296,7 +296,7 @@ static void c_stop(struct seq_file *m, void *v)
>  {
>  }
>  
> -struct seq_operations cpuinfo_op = {
> +const struct seq_operations cpuinfo_op = {

This is declared non const in fs/proc/proc_misc.c (one of the reasons why
it should be decalred in a header file ...)

The others look good, though.
-- 
Cheers,
Stephen Rothwell                    sfr at canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20080123/4931a155/attachment.pgp>


More information about the Linuxppc-dev mailing list