[PATCH 2/4] Create and hook up of_platform_device_shutdown
sfr at canb.auug.org.au
Wed Jan 23 01:34:04 EST 2008
Just a couple of things.
On Tue, 22 Jan 2008 22:04:40 +1100 (EST) Michael Ellerman <michael at ellerman.id.au> wrote:
> +static void of_platform_device_shutdown(struct device * dev)
No space, please.
Also, I wonder if we should check that the drivers that already have
specified a shutdown routine (drivers/input/misc/sparcspkr.c,
drivers/usb/host/ohci-ppc-of.c and drivers/watchdog/mpc5200_wdt.c) are
actually ok if it actually gets called. :-)
Also, patches like this should be cc'd to (at least) the sparc guys
(sparclinux at vger.kernel.org) since they share this stuff with us, now.
Stephen Rothwell sfr at canb.auug.org.au
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: not available
More information about the Linuxppc-dev