[PATCH] autodetect serial console on efika

[Grant Likely]

On 1/21/08, Olaf Hering <olaf at aepfle.de> wrote:
> On Mon, Jan 21, Grant Likely wrote:
>
> > On 1/21/08, Olaf Hering <olaf at aepfle.de> wrote:
> > >
> > > Efika boards have to be booted with console=ttyPSC0 unless there is a
> > > graphics card plugged in. Detect if the firmware stdout is the serial
> > > connector.
> > >
> > > Signed-off-by: Olaf Hering <olaf at aepfle.de>
> >
> > Hrrrum; I think this is a good idea, but I'm not thrilled with the
> > approach.  Here are my concerns:
> >
> > - Determining that linux,stdout-path points to a PSC should should be
> > done in common code.  It's useful for all 5200 boards, not just the
> > Efika.  (However, if 'failsafe' processing is efika specific, then it
> > can stay in efika.c).  This might be best done within the PSC driver
> > itself, but I'm not sure.
> > - Recognizing a psc node should be done by inspecting the compatible
> > property, not by device_type and model properties.
>
> I dont have any other 5200 hardware to test a different patch.
> Please improve my version and submit it for inclusion.

Heh; that's okay, I and others can test on other hardware; but it's
still appropriate for you to move the matching code into the PSC
driver proper.  Otherwise, getting it in to mainline for 2.6.25
depends on how much time I get free in the next 2 weeks.

g.


-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.