jwboyer at linux.vnet.ibm.com
Tue Jan 22 01:01:57 EST 2008
On Thu, 17 Jan 2008 15:23:22 -0500
Sean MacLennan <smaclennan at pikatech.com> wrote:
> The taco, er warp, has a watchdog timer built into the fpga. The
> watchdog is very trivial and very tied to the warp. I have put it has
> part of the platform code rather than a standalone module.
> Two reasons for this: one, once started it can't be stopped. A module
> unload would be fatal ;) Two, it is so closely tied to the taco that it
> really has no use otherwise.
The first isn't much of a reason. The watchdog on the 44x and FSL
Book-E cores have the same behavior.
> The platform always starts the watchdog, assuming you asked for the
> watchdog, but does not enable it until hit from user mode.
> What is the general feeling about this implementation? I am not
> submitting this for inclusion in the kernel right now, just feeling out
> what others think.
I'm not thrilled with it being in the platform file itself. It should
really go into drivers/watchdog. It's OK that the watchdog is tied to
Warp, that really isn't an issue. Just make it depend on Warp in the
Kconfig file. And you can select it in your board config so that it's
built in-kernel and not as a module.
The code itself looks pretty clean.
More information about the Linuxppc-dev