[PATCH v5] [POWERPC] Add LED driver for Promess Motion-PRO board.

[Stephen Rothwell]

Hi Marian,

On Thu, 17 Jan 2008 19:09:17 +0100 Marian Balakowicz <m8 at semihalf.com> wrote:
>
> +static int __devinit mpled_probe(struct of_device *op,
> +				 const struct of_device_id *match)
> +{
> +	struct motionpro_led *mpled;
> +	const unsigned int *of_blink_delay;
> +	const char *label;
> +	int err;
> +
> +	dev_dbg(&op->dev, "mpled_probe: node=%s (op=%p, match=%p)\n",
> +		op->node->name, op, match);
> +
> +	mpled = kzalloc(sizeof(*mpled), GFP_KERNEL);
> +	if (!mpled)
> +		return -ENOMEM;
> +
> +	mpled->gpt = of_iomap(op->node, 0);
> +	if (!mpled->gpt) {
> +		printk(KERN_ERR __FILE__ ": "
> +			"Error mapping GPT registers for LED %s\n",
> +			op->node->full_name);
> +		err = -EIO;
> +		goto err_free;
> +	}
> +
> +	/* initialize GPT for LED use */
> +	mpled_init_led(&mpled->gpt->mode);
> +
> +	spin_lock_init(&mpled->led_lock);
> +	mpled->mode = LED_MODE_KERNEL;
> +
> +	/* get LED label, used to register led classdev */
> +	label = of_get_property(op->node, "label", NULL);
> +	if (label == NULL) {
> +		printk(KERN_ERR __FILE__ ": "
> +			"No label property provided for LED %s\n",
> +			op->node->full_name);
> +		err = -EINVAL;
> +		goto err_free;

		goto err;

> +static struct of_device_id mpled_match[] = {

Make this const, please.

-- 
Cheers,
Stephen Rothwell                    sfr at canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20080118/2a071bf8/attachment.pgp>