[Add mpc5121 support PATCH v2 3/8] Basic Freescale MPC512x support

Stephen Rothwell sfr at canb.auug.org.au
Thu Jan 17 10:02:54 EST 2008


Hi John,

On Wed, 16 Jan 2008 14:37:22 -0700 John Rigby <jrigby at freescale.com> wrote:
>
> +++ b/arch/powerpc/platforms/512x/mpc5121_ads.c

> +static void __init mpc5121_ads_init_IRQ(void)
> +{
> +	struct device_node *np;
> +
> +	np = of_find_compatible_node(NULL, NULL, "fsl,ipic");
> +	if (!np)
> +		return;
> +
> +	ipic_init(np, 0);

You need an op_node_put(np) here.  ipic_init will do another of_node_get()
if it keeps a reference to np.

-- 
Cheers,
Stephen Rothwell                    sfr at canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20080117/cfa2afa4/attachment.pgp>


More information about the Linuxppc-dev mailing list