[PATCH 2/2] [POWERPC] 4xx: Add AMCC Haleakala (405EXr) dts

David Gibson david at gibson.dropbear.id.au
Wed Jan 16 16:52:43 EST 2008


On Wed, Jan 16, 2008 at 06:04:56AM +0100, Stefan Roese wrote:
> On Wednesday 16 January 2008, David Gibson wrote:
> > On Tue, Jan 15, 2008 at 08:09:25AM +0100, Stefan Roese wrote:
[snip]
> > > +			RGMII0: emac-rgmii at ef600b00 {
> > > +				device_type = "rgmii-interface";
> >
> > And especially not here.
> 
> Ok.
> 
> Your comments are valid for some of the other 4xx dts files too. Should I 
> create a patch that removes these device-types there too?

Yes please :).

[snip]
> > Oh, for crying out loud.  They put dcrs on the bridge as well as MMIO
> > registers. *facepalm*
> 
> Yep. PCIe on 4xx has DCR, SDR *and* MMIO registers.

Ungh.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson



More information about the Linuxppc-dev mailing list