[PATCH 1/4] powerpc: mv64x60 - Use early_* PCI accessors for hotswap reg

[Mark A. Greer]

On Tue, Jan 15, 2008 at 10:19:36AM +1100, Stephen Rothwell wrote:

> Hi Mark,

Hi Stephen.  Thanks for taking the time to review these patches.

> On Mon, 14 Jan 2008 15:51:50 -0700 "Mark A. Greer" <mgreer at mvista.com> wrote:
> >
> > +static inline struct pci_controller *mv64x60_find_hose(u32 idx)
> > +{
> > +	struct device_node *phb;
> > +	struct pci_controller *hose;
> > +	const u32 *prop;
> > +	int len;
> > +
> > +	for_each_compatible_node(phb, "pci", "marvell,mv64360-pci") {
> > +		prop = of_get_property(phb, "cell-index", &len);
> > +		if (prop && (len == sizeof(prop)) && (*prop == idx)) {
> > +			hose = pci_find_hose_for_OF_device(phb);
> > +			of_node_put(phb);
> > +			return hose;
> > +		}
> > +	}
> > +
> > +	return NULL;
> > +}
> 
> I would think that this is way to big to inline ...

Yeah, I suppose.  I'm not sure why I made it an inline, TBH.  I'll make
it a "real" routine.

Mark