[PATCH] [SERIAL] qe-uart: add support for Freescale QUICCEngine UART
timur at freescale.com
Wed Jan 16 02:03:32 EST 2008
Kumar Gala wrote:
> what is the define for? you commented all the others :)
I thought you said there were no more issues? :-)
>> +#define UCC_WAIT_CLOSING 100
This is how long to wait after receiving a close request for characters to be
sent out before actually closing the device. I just used the same value as the
CPM serial driver.
>> + u16 tx_state; /* 0xC6, TX state */
>> + * Set the modem control lines
>> + *
>> + * We currently don't support setting modem control lines, but this
>> + * needs to exist, otherwise the kernel will panic.
>> + */
>> +void qe_uart_set_mctrl(struct uart_port *port, unsigned int mctrl)
> What's the issue w/support of this? (maybe a comment related to why its
> not supported -- if not here in the git commit message)
I didn't want to add any serial functionality that wasn't in the CPM serial
driver, mostly because I don't really understand the technical details of serial
communication at this level. I figured if it's okay for the CPM driver not to
handle modem control, then the QE driver doesn't have to do it either.
>> +static void qe_uart_enable_ms(struct uart_port *port)
> same question as above.
I suppose you want me to post another version of this patch?
Linux kernel developer at Freescale
More information about the Linuxppc-dev