[DTC PATCH] libfdt: Add ft_get_next_node(), ft_get_next_prop(), and ft_getprop_offset().

Stephen Rothwell sfr at canb.auug.org.au
Tue Jan 15 09:54:34 EST 2008

On Mon, 14 Jan 2008 16:44:33 -0600 Scott Wood <scottwood at freescale.com> wrote:
> Stephen Rothwell wrote:
> >> +++ b/libfdt/libfdt.h
> > 
> >> +#define FDT_ERR_BADDEPTH	8
> > 
> > Wouldn't it have been less intrusive to just use the next error number
> > rather than inserting this here?
> Yes, but then either the order in errtable[] wouldn't match the order in 
> the header file, or the error type grouping would be broken.
> If we want to maintain such a grouping, we should probably leave some 
> number space between the groups.


> "pointer to a string" could be interpreted as "char *", not "char **".

Yeah, it has always been a bit ambiguous.

> I'll fix the others; thanks for pointing them out.

No worries.
Stephen Rothwell                    sfr at canb.auug.org.au
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20080115/179c3281/attachment.pgp>

More information about the Linuxppc-dev mailing list