RFC: Only deal with apple fix if res is memory

Kumar Gala galak at kernel.crashing.org
Sun Jan 13 10:05:26 EST 2008


On Jan 11, 2008, at 4:03 PM, Benjamin Herrenschmidt wrote:

>
> On Fri, 2008-01-11 at 10:38 -0600, Kumar Gala wrote:
>> Ben,
>>
>> Will this impact the apple fix?  I'm getting some _IO cases hitting  
>> this.
>
> No, your fix is right, it's a bug to compare against pci_mem_offset  
> and
> not check if it's a memory resource in the first place. I would  
> suggest
> that you do the res->flags test first in the if () statement for  
> clarity
> though.

ok, will clean up the patch and resend.

- k



More information about the Linuxppc-dev mailing list