[PATCH V3] [POWERPC] Add common clock setting routine mpc52xx_psc_set_clkdiv()

[Stephen Rothwell]

On Thu, 10 Jan 2008 08:01:09 -0700 "Grant Likely" <grant.likely at secretlab.ca> wrote:
>
> On 1/10/08, Stephen Rothwell <sfr at canb.auug.org.au> wrote:
> > Hi Grant,
> >
> > On Wed, 09 Jan 2008 22:26:30 -0700 Grant Likely <grant.likely at secretlab.ca> wrote:
> > >
> > > +mpc52xx_map_common_devices(void)
> > >  {
> >
> > > +     /* Clock Distribution Module, used by PSC clock setting function */
> > > +     np = of_find_matching_node(NULL, mpc52xx_cdm_ids);
> >
> > What happens if we find no node?
> 
> Both of_iomap and of_put fail gracefully if np is NULL.  IIRC that was
> done on purpose so this exact thing could be done.
> 
> Users of mpc52xx_cdm (and the others done in this style) all check for
> mpc52xx_cdm being NULL before dereferencing.

Excellent, thanks.

-- 
Cheers,
Stephen Rothwell                    sfr at canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20080111/3c838231/attachment.pgp>