Platform matching style (was:: [RFC] add phy-handle property for fec_mpc52xx)
grant.likely at secretlab.ca
Fri Jan 11 02:31:18 EST 2008
On 1/9/08, Benjamin Herrenschmidt <benh at kernel.crashing.org> wrote:
> As much as I despise having to work around firmware bugs, it looks
> indeed like this one has been broken for way too long to the point where
> users are being hurt, distros are being hurt, and telling people to
> whack things in nvramrc is just plain gross, so let's merge it.
The Efika has device_type = "chrp" in the root node, but in Linux
Efika support does not use CHRP, it uses
arch/powerpc/platforms/52xx/efika.c. However, if CHRP support is
compiled in then it will see the chrp device_type and bind to it
before efika.c has a chance to probe. I see three reasonable
solutions to this:
1. Apply a device tree fixup to change device_type from "chrp" to
"efika" (the current solution)
2. Modify chrp_probe() to check specifically for the Efika when probing
3. Modify the link order so that Efika is probed before CHRP.
All three of these solutions will work, but I'd like to get opinions
on which is stylistically the best approach (or if there is another
approach I'm missing).
In general, I'm trying to reduce the Efika fixups down to only what is
absolutely necessary and as much as possible work with the provided
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
More information about the Linuxppc-dev