[PATCH 2/3] Handle absolute pathnames correctly in dtc_open_file.
David Gibson
david at gibson.dropbear.id.au
Thu Jan 10 16:09:58 EST 2008
On Sun, Jan 06, 2008 at 04:46:24PM -0600, Scott Wood wrote:
> On Sun, Jan 06, 2008 at 02:37:16PM +1100, David Gibson wrote:
> > > out:
> > > + free((void *)file->dir);
> >
> > That cast shouldn't be there.
>
> It generates a constness warning otherwise. I was on the fence over
> whether to just remove the constness (even though the data is never
> modified during its lifetime); would that be preferable?
I think that is preferable.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
More information about the Linuxppc-dev
mailing list