[PATCH v6] qe: add ability to upload QE firmware

Timur Tabi timur at freescale.com
Wed Jan 9 02:29:21 EST 2008

Stephen Rothwell wrote:

> Why not:
> 	const u64 *iprop;
> 	int len;
> 	iprop = of_get_property(fs, "extended-modes", &len);
> 	if (iprop && (len == sizeof(u64))
> 		qe_firmware_info.extended_modes = *iprop;

Actually, I like my way better, because then I don't have to define 'len', and I 
don't have to define two integer property variables one for u32 and one for u64. 
  Besides, now that I'm at version 6, I'd rather not post updates for minor 
stylistic changes.

Timur Tabi
Linux kernel developer at Freescale

More information about the Linuxppc-dev mailing list