[PATCH] add MPC837x MDS board default device tree

[Kumar Gala]

On Dec 14, 2007, at 2:12 AM, Kumar Gala wrote:

>
> On Dec 6, 2007, at 8:01 PM, David Gibson wrote:
>
>> On Wed, Dec 05, 2007 at 06:37:53PM +0800, Li Yang wrote:
>>> Signed-off-by: Li Yang <leoli at freescale.com>
>>> ---
>>> Update SATA nodes; remove serdes nodes; add aliases and labels.
>>>
>>> arch/powerpc/boot/dts/mpc8377_mds.dts |  270 +++++++++++++++++++++++
>>> ++++++++
>>> arch/powerpc/boot/dts/mpc8378_mds.dts |  256 +++++++++++++++++++++++
>>> ++++++
>>> arch/powerpc/boot/dts/mpc8379_mds.dts |  284 +++++++++++++++++++++++
>>> ++++++++++
>>> 3 files changed, 810 insertions(+), 0 deletions(-)
>>> create mode 100644 arch/powerpc/boot/dts/mpc8377_mds.dts
>>> create mode 100644 arch/powerpc/boot/dts/mpc8378_mds.dts
>>> create mode 100644 arch/powerpc/boot/dts/mpc8379_mds.dts
>>>
>>> diff --git a/arch/powerpc/boot/dts/mpc8377_mds.dts b/arch/powerpc/
>>> boot/dts/mpc8377_mds.dts
>>> new file mode 100644
>>> index 0000000..919ffd0
>>> --- /dev/null
>>> +++ b/arch/powerpc/boot/dts/mpc8377_mds.dts
>> [snip]
>>> +	aliases {
>>> +		ethernet0 = "/soc at e0000000/ethernet at 24000";
>>> +		ethernet1 = "/soc at e0000000/ethernet at 25000";
>>> +		serial0 = "/soc at e0000000/serial at 4500";
>>> +		serial1 = "/soc at e0000000/serial at 4600";
>>> +		pci0 = "/pci at e0008500";
>>
>> You can use path references for these now.
>>
>>> +	};
>>> +
>>> +	cpus {
>>> +		#address-cells = <1>;
>>> +		#size-cells = <0>;
>>> +
>>> +		PowerPC,837x at 0 {
>>
>> This should absolutely not have a "x" in it.  Either have an exact
>> model, or just use "cpu at 9" (in which case you can put the model in
>> "compatible").
>>
>> [snip]
>>> +		i2c at 3000 {
>>> +			device_type = "i2c";
>>
>> Drop the device_type.  No "i2c" device_type class is defined.
>>
>> [snip]
>>> +		/* phy type (ULPI, UTMI, UTMI_WIDE, SERIAL) */
>>> +		usb at 23000 {
>>> +			device_type = "usb";
>>
>> Drop device_type here too.
>>
>>> +			compatible = "fsl-usb2-dr";
>>> +			reg = <23000 1000>;
>>> +			#address-cells = <1>;
>>> +			#size-cells = <0>;
>>> +			interrupt-parent = < &ipic >;
>>> +			interrupts = <26 8>;
>>> +			phy_type = "utmi_wide";
>>> +		};
>>> +
>>> +		mdio at 24520 {
>>> +			device_type = "mdio";
>>> +			compatible = "gianfar";
>>
>> Grr... not your fault, but this crap in the gianfar driver where it
>> uses the same compatible property for the mdio and MAC has to be
>> fixed.
>
> I've fixed this now.  Look at my tree/patch.
>
>> [snip]
>>
>>> +		serial1:serial at 4600 {
>>
>> Standard style puts a space after the colon.
>>
>>> +			device_type = "serial";
>>> +			compatible = "ns16550";
>>> +			reg = <4600 100>;
>>> +			clock-frequency = <0>;
>>> +			interrupts = <a 8>;
>>> +			interrupt-parent = < &ipic >;
>>> +		};
>>> +
>>> +		crypto at 30000 {
>>> +			model = "SEC3";
>>> +			compatible = "talitos";
>>
>> This driver, also, needs fixing to recognize a better formatted
>> compatible property.
>
> Can you respin with David's changes as well as mirror my cleanup of
> the other 83xx/85xx .dts


Any updates on new versions of the .dts for mpc837x?

- k