[PATCH 4/8] pseries: phyp dump: use sysfs to release reserved mem

Stephen Rothwell sfr at canb.auug.org.au
Tue Jan 8 14:45:37 EST 2008


On Mon, 07 Jan 2008 18:21:57 -0600 Manish Ahuja <ahuja at austin.ibm.com> wrote:
>
> +static int __init phyp_dump_setup(void)
> +{
>
> +	/* Is there dump data waiting for us? */
> +	rtas = of_find_node_by_path("/rtas");
> +	dump_header = of_get_property(rtas, "ibm,kernel-dump", &header_len);
                                                               ^^^^^^^^^^^
You could pass NULL here as header_len appears to be unused. Also you
need "of_node_put(rtas)" somewhere (probably just here would do).

> +	if (dump_header == NULL) {
> +		release_all();
> +		return 0;
> +	}
-- 
Cheers,
Stephen Rothwell                    sfr at canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20080108/0bf4ab7d/attachment.pgp>


More information about the Linuxppc-dev mailing list