[PATCH 3/3] USB device tree cleanups

[Li Yang]

> -----Original Message-----
> From: linuxppc-dev-bounces+leoli=freescale.com at ozlabs.org 
> [mailto:linuxppc-dev-bounces+leoli=freescale.com at ozlabs.org] 
> On Behalf Of Stephen Rothwell
> Sent: Tuesday, January 08, 2008 7:10 AM
> To: Li Yang
> Cc: linuxppc-dev at ozlabs.org; paulus at samba.org
> Subject: Re: [PATCH 3/3] USB device tree cleanups
> 
> On Mon,  7 Jan 2008 20:03:20 +0800 Li Yang 
> <leoli at freescale.com> wrote:
> >
> > +++ b/arch/powerpc/sysdev/fsl_soc.c
> > @@ -533,9 +533,7 @@ static int __init fsl_usb_of_init(void)
> >  		*usb_dev_dr_client = NULL;
> >  	int ret;
> >  
> > -	for (np = NULL, i = 0;
> > -	     (np = of_find_compatible_node(np, "usb", 
> "fsl-usb2-mph")) != NULL;
> > -	     i++) {
> > +	for_each_compatible_node(np, NULL, "fsl-usb2-mph") {
> 
> 'i' is no longer being updated (or indeed set to anything) 
> but is still used in the loop - at least in Paulus' current tree).

Good catch. My careless mistake.  Thanks.

- Leo