[RFC 1/2] mpc5200: Add common clock setting routine mpc52xx_set_psc_clkdiv()
Stephen Rothwell
sfr at canb.auug.org.au
Tue Jan 8 12:04:09 EST 2008
On Mon, 07 Jan 2008 12:03:59 -0700 Grant Likely <grant.likely at secretlab.ca> wrote:
>
> +++ b/arch/powerpc/platforms/52xx/mpc52xx_common.c
>
> -static struct of_device_id __init mpc52xx_ids[] = {
Why not just leave this here and mark in __initdata?
> +/**
> + * mpc52xx_declare_of_platform_devices: register internal devices and children
> + * of the localplus bus to the of_platform
> + * bus.
> + */
> void __init
> mpc52xx_declare_of_platform_devices(void)
> {
> + const static struct of_device_id mpc52xx_bus_ids[] = {
Or just mark it __initdata instead of const?
> + { .compatible = "fsl,mpc5200-immr", },
> + { .compatible = "fsl,lpb", },
> + { .type = "builtin", .compatible = "mpc5200", }, /* efika */
> + { .type = "soc", .compatible = "mpc5200", }, /* old */
And you lost the comment about the last two being deprecated mates.
> +mpc52xx_map_common_devices(void)
> {
> struct device_node *np;
> - struct of_device_id gpt_ids[] = {
> + const static struct of_device_id gpt_ids[] = {
Again __initdata?
> + const static struct of_device_id cdm_ids[] = {
And again?
--
Cheers,
Stephen Rothwell sfr at canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20080108/52154634/attachment.pgp>
More information about the Linuxppc-dev
mailing list