[PATCH 2/7] powerpc: allow localbus compatible serial ports for console device

Arnd Bergmann arnd at arndb.de
Tue Jan 8 01:33:46 EST 2008


On Monday 07 January 2008, Paul Gortmaker wrote:
> +       /* Next, fill our array with any localbus serial ports */
> +       for_each_compatible_node(np, "serial", "ns16550") {
> +               struct device_node *lbs = of_get_parent(np);
> +               if (lbs && of_device_is_compatible(lbs, "localbus")) {
> +                       index = add_legacy_soc_port(np, np);
> +                       if (index >= 0 && np == stdout)
> +                               legacy_serial_console = index;
> +               }
> +               of_node_put(lbs);
> +       }
> +

This is getting a little silly. Can't you finally unify the code
so it checks for any 8250/16450/16550 on any soc/isa/tsi-bridge/opb/localbus?

	Arnd <><


More information about the Linuxppc-dev mailing list