[PATCH] add gpiolib support for mpc5200

[Stephen Rothwell]

Hi Sascha,

One small comment.

On Thu, 24 Apr 2008 17:36:59 +0200 Sascha Hauer <s.hauer at pengutronix.de> wrote:
>
> +#include <asm/of_platform.h>

Never include <asm/of_platform.h>, use <linux/of_platform.h>

> +static struct of_device_id mpc52xx_wkup_gpiochip_match[] = {

const, please.

OK, I lied about only one comment :-)

> +static struct of_device_id mpc52xx_simple_gpiochip_match[] = {

const, again.

> +static struct of_device_id mpc52xx_gpt_gpiochip_match[] = {

Another one.

Also, I don't think you need to include <asm/prom.h>
-- 
Cheers,
Stephen Rothwell                    sfr at canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20080425/07eefd5d/attachment.pgp>