[RFC/POWERPC] mpc5200: remove "mpc5200b-*" from compatible lists in dts files
grant.likely at secretlab.ca
Sun Apr 20 02:23:50 EST 2008
On Sat, Apr 19, 2008 at 3:23 AM, Segher Boessenkool
<segher at kernel.crashing.org> wrote:
> > The mpc5200b is a bug fix of the mpc5200 with a few incompatible changes.
> > By rights, the current dts trees are the most "correct", but in practical
> > purposes there is no value in the 5200b devices having 2 compatible
> > entries for each internal peripheral node. Freescale has done a good job
> > of documenting exactly where the incompatibilities lie, so it restrict
> > the extra compatible properties to devices with *documented* changes.
> And what happens when later an "undocumented change" is found? The
> device tree should always list the exact version of device used, even
> if all clients (i.e., the Linux kernel) only use the less-specific
> "compatible" value; that way, if a need to distinguish arises later
> (e.g., a model-specific bug workaround), a client can detect the exact
> model of device without needing a new device tree (that the client in
> general has no control over).
Yes, I fully agree and understand that. However, even that doesn't
fully solve the problem. At what level do you stop trying to describe
the device versions in the device tree? What about the case where an
earlier silicon version has an undocumented errata? At some point,
compatible doesn't help us and we need to resort to looking at other
factors (like PVR/SVR) to determine what the device really is.
Early on I decided to differentiate between the 5200 and the 5200b;
however, from a practical sense they really are the same part and
there is no practical advantage to differentiating between them.
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
More information about the Linuxppc-dev