[RFC/POWERPC] mpc5200: remove "mpc5200b-*" from compatible lists in dts files

Segher Boessenkool segher at kernel.crashing.org
Sat Apr 19 19:23:57 EST 2008


> The mpc5200b is a bug fix of the mpc5200 with a few incompatible 
> changes.
> By rights, the current dts trees are the most "correct", but in 
> practical
> purposes there is no value in the 5200b devices having 2 compatible
> entries for each internal peripheral node.  Freescale has done a good 
> job
> of documenting exactly where the incompatibilities lie, so it restrict
> the extra compatible properties to devices with *documented* changes.

And what happens when later an "undocumented change" is found?  The
device tree should always list the exact version of device used, even
if all clients (i.e., the Linux kernel) only use the less-specific
"compatible" value; that way, if a need to distinguish arises later
(e.g., a model-specific bug workaround), a client can detect the exact
model of device without needing a new device tree (that the client in
general has no control over).

> Removing the extra 'b' fields makes the device trees smaller

That's nice in general, but it hardly overrides more serious concerns.


Segher




More information about the Linuxppc-dev mailing list