[PATCH 1/3] powerpc: Add support for Wind River SBC8641D board

Michael Ellerman michael at ellerman.id.au
Fri Apr 11 10:38:43 EST 2008


On Fri, 2008-04-11 at 10:05 +1000, Stephen Rothwell wrote:
> Hi Paul,
> 
> Just a couple of comments.
> 
> On Thu, 10 Apr 2008 19:22:17 -0400 Paul Gortmaker <paul.gortmaker at windriver.com> wrote:
> >
> > +++ b/arch/powerpc/platforms/86xx/sbc8641d.c
> > +#undef DEBUG
> > +
> > +#ifdef DEBUG
> > +#define DBG(fmt...) do { printk(KERN_ERR fmt); } while(0)
>                                    ^^^^^^^^
> Not KERN_DEBUG?  Also, if you include linux/kernel.h you can use pr_debug() instead.

s/Also, if you include/Please include/

We don't need more hand-rolled debug macros :)

cheers

-- 
Michael Ellerman
OzLabs, IBM Australia Development Lab

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20080411/1d3ccb0a/attachment.pgp>


More information about the Linuxppc-dev mailing list