[PATCH 1/3] powerpc: Add support for Wind River SBC8641D board

[Stephen Rothwell]

Hi Paul,

Just a couple of comments.

On Thu, 10 Apr 2008 19:22:17 -0400 Paul Gortmaker <paul.gortmaker at windriver.com> wrote:
>
> +++ b/arch/powerpc/platforms/86xx/sbc8641d.c
> +#undef DEBUG
> +
> +#ifdef DEBUG
> +#define DBG(fmt...) do { printk(KERN_ERR fmt); } while(0)
                                   ^^^^^^^^
Not KERN_DEBUG?  Also, if you include linux/kernel.h you can use pr_debug() instead.

> +sbc8641_init_irq(void)
> +{
> +	struct mpic *mpic1;
> +	struct device_node *np;
> +	struct resource res;
> +
> +	/* Determine PIC address. */
> +	np = of_find_node_by_type(NULL, "open-pic");
> +	if (np == NULL)
> +		return;
> +	of_address_to_resource(np, 0, &res);
> +
> +	/* Alloc mpic structure and per isu has 16 INT entries. */
> +	mpic1 = mpic_alloc(np, res.start,
> +			MPIC_PRIMARY | MPIC_WANTS_RESET | MPIC_BIG_ENDIAN,
> +			0, 256, " MPIC     ");
> +	BUG_ON(mpic1 == NULL);
> +
> +	mpic_init(mpic1);

You need an of_node_put(np) in here somewhere (probably after the mpic_alloc).

-- 
Cheers,
Stephen Rothwell                    sfr at canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20080411/3867e71c/attachment.pgp>