[PATCH v3 9/9] add MPC837x MDS board default device tree

Li Yang-r58472 LeoLi at freescale.com
Thu Oct 18 23:46:44 EST 2007


 

> -----Original Message-----
> From: Kumar Gala [mailto:galak at kernel.crashing.org] 
> Sent: Wednesday, October 17, 2007 9:59 PM
> To: David Gibson
> Cc: Li Yang-r58472; paulus at samba.org; linuxppc-dev at ozlabs.org
> Subject: Re: [PATCH v3 9/9] add MPC837x MDS board default device tree
> 
> 
> On Oct 14, 2007, at 7:37 PM, David Gibson wrote:
> 
> > On Fri, Oct 12, 2007 at 09:28:48PM +0800, Li Yang wrote:
> >> Signed-off-by: Li Yang <leoli at freescale.com>
> >> ---
> >>  arch/powerpc/boot/dts/mpc8377_mds.dts |  288 +++++++++++++++++++++
> >> +++++++++
> >>  arch/powerpc/boot/dts/mpc8378_mds.dts |  268 +++++++++++++++++++++
> >> +++++++
> >>  arch/powerpc/boot/dts/mpc8379_mds.dts |  308 +++++++++++++++++++++
> >> ++++++++++++
> >>  3 files changed, 864 insertions(+), 0 deletions(-)  create mode 
> >> 100644 arch/powerpc/boot/dts/mpc8377_mds.dts
> >>  create mode 100644 arch/powerpc/boot/dts/mpc8378_mds.dts
> >>  create mode 100644 arch/powerpc/boot/dts/mpc8379_mds.dts
> >>
> >> diff --git a/arch/powerpc/boot/dts/mpc8377_mds.dts
> >> b/arch/powerpc/boot/dts/mpc8377_mds.dts
> > [snip]
> >> +	soc837x at e0000000 {
> >> +		#address-cells = <1>;
> >> +		#size-cells = <1>;
> >> +		device_type = "soc";
> >> +		ranges = <0 e0000000 00100000>;
> >> +		reg = <e0000000 00000200>;
> >> +		bus-frequency = <0>;
> >> +
> >> +		wdt at 200 {
> >> +			device_type = "watchdog";
> >
> > Drop this device_type.
> >
> >> +			compatible = "mpc83xx_wdt";
> >> +			reg = <200 100>;
> >> +		};
> >> +
> >> +		i2c at 3000 {
> >> +			device_type = "i2c";
> >
> > And this one.
> 
> I've asked Leo to leave this one as all other fsl boards do 
> this and the code depends on it.  There was some discussion 
> about this but I wasn't sure if it was closed or not.

I'm afraid not only i2c but also watchdog and spi need device_type now.
Shall we proceed removing the type check?

- Leo



More information about the Linuxppc-dev mailing list