[POWERPC 03/15] [POWERPC] TQM5200 board support

Grant Likely grant.likely at secretlab.ca
Mon Oct 8 17:54:15 EST 2007


On 10/8/07, Wolfgang Denk <wd at denx.de> wrote:
> In message <fa686aa40710072321g3494b243w341e2b09117c3695 at mail.gmail.com> you wrote:
> >
> > > +       port_config &= ~0x03000000;     /* ATA CS is on csb_4/5         */
> > > +       port_config |=  0x01000000;
> >
> > Are you *sure* you want this?  You should only be touching port_config
> > if firmware fails to set it up correctly.  Don't blindly copy what was
> > done for the lite5200.
> >
> > Lite5200 touches it because firmware does *not* do the right thing at
> > the moment.
>
> Why don't we fix it in U-Boot, then, and get rid of this in Linux?

Mostly because I haven't gotten to it yet.  :-/

g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
grant.likely at secretlab.ca
(403) 399-0195



More information about the Linuxppc-dev mailing list