[POWERPC 03/15] [POWERPC] TQM5200 board support

[Wolfgang Denk]

In message <fa686aa40710072321g3494b243w341e2b09117c3695 at mail.gmail.com> you wrote:
>
> > +       port_config &= ~0x03000000;     /* ATA CS is on csb_4/5         */
> > +       port_config |=  0x01000000;
> 
> Are you *sure* you want this?  You should only be touching port_config
> if firmware fails to set it up correctly.  Don't blindly copy what was
> done for the lite5200.
> 
> Lite5200 touches it because firmware does *not* do the right thing at
> the moment.

Why don't we fix it in U-Boot, then, and get rid of this in Linux?


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The average woman would rather have beauty than brains,  because  the
average man can see better than he can think.