[patch 09/18] PS3: System-bus rework

Geert Uytterhoeven Geert.Uytterhoeven at sonycom.com
Tue Jun 12 01:45:44 EST 2007


On Mon, 11 Jun 2007, Geoff Levand wrote:
> Milton Miller wrote:
> >> --- a/arch/powerpc/platforms/ps3/mm.c
> >> +++ b/arch/powerpc/platforms/ps3/mm.c
> >> -#define DBG(fmt...) do{if(0)printk(fmt);}while(0)
> >> +#define DBG(fmt...) do { if (0) printk(fmt);} while (0)
> > 
> > While there isn't a style guide for one line defines, while you're 
> > adding spaces add one more after the ; before the } where a new line 
> > would normally appear.
> 
> 
> I don't even like the original.  I planned to replace it with the
> following, and will do so now.
> 
> static inline int __attribute__ ((format (printf, 1, 2))) DBG(
> 	const char *fmt, ...) {return 0;}

We have the exact same definition (albeit with a different name, `pr_debug'),
in include/linux/kernel.h...

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- Sony Network and Software Technology Center Europe (NSCE)
Geert.Uytterhoeven at sonycom.com ------- The Corporate Village, Da Vincilaan 7-D1
Voice +32-2-7008453 Fax +32-2-7008622 ---------------- B-1935 Zaventem, Belgium



More information about the Linuxppc-dev mailing list