[PATCH 5/7] powerpc: Replace ppc_md.power_off with pm_power_off

Benjamin Herrenschmidt benh at kernel.crashing.org
Wed Dec 5 06:55:52 EST 2007


On Tue, 2007-12-04 at 11:01 -0700, Mark A. Greer wrote:
> On Tue, Dec 04, 2007 at 06:23:09PM +1100, Benjamin Herrenschmidt wrote:
> > 
> > On Mon, 2007-12-03 at 22:48 -0700, Mark A. Greer wrote:
> > > From: Mark A. Greer <mgreer at mvista.com>
> > > 
> > > The ppc_md.power_off hook performs the same function that the
> > > pm_power_off hook is supposed to.  However, it is powerpc-specific
> > > and prevents kernel drivers (e.g., IPMI) from changing how a platform
> > > is powered off.  So, get rid of ppc_md.power_off and replace it with
> > > pm_power_off.
> > 
> > I'm less happy with that one... probably aesthetics :-)
> > 
> > Can't we just have the generic code call pm_power_off and ppc_md and
> > which ever powers the machine off wins ?
> 
> Yes, that would be easy to do.  Seems like duplication though.
> If you are sure you're okay with the duplication, I'll do that.

Let's ask Paulus what he thinks.

Ben.





More information about the Linuxppc-dev mailing list