[PATCH 5/7] powerpc: Replace ppc_md.power_off with pm_power_off

Mark A. Greer mgreer at mvista.com
Wed Dec 5 05:01:48 EST 2007


On Tue, Dec 04, 2007 at 06:23:09PM +1100, Benjamin Herrenschmidt wrote:
> 
> On Mon, 2007-12-03 at 22:48 -0700, Mark A. Greer wrote:
> > From: Mark A. Greer <mgreer at mvista.com>
> > 
> > The ppc_md.power_off hook performs the same function that the
> > pm_power_off hook is supposed to.  However, it is powerpc-specific
> > and prevents kernel drivers (e.g., IPMI) from changing how a platform
> > is powered off.  So, get rid of ppc_md.power_off and replace it with
> > pm_power_off.
> 
> I'm less happy with that one... probably aesthetics :-)
> 
> Can't we just have the generic code call pm_power_off and ppc_md and
> which ever powers the machine off wins ?

Yes, that would be easy to do.  Seems like duplication though.
If you are sure you're okay with the duplication, I'll do that.

Mark



More information about the Linuxppc-dev mailing list