Fix interrupt clearing in kdump shutdown sequence

Michael Ellerman michael at ellerman.id.au
Thu Sep 14 13:07:29 EST 2006


On Tue, 2006-09-12 at 17:48 +0530, Mohan Kumar M wrote:
> Hi,
> 
> Some times HVC console on a PPC machine may have pending interrupts and
> in this case kdump shutdown sequence created problem by calling
> chip->end. This should be chip->eoi(). The attached patch fixes this
> issue. Tested on POWER5 box.

Nice catch.

Looks like chip->end() used to == xics_end_irq(), but that vanished and
became xics_eio_(direct|lpar) and got hooked up to chip->eoi(). We
should check there are no other callers of chip->end() which really want
chip->eoi().

cheers

-- 
Michael Ellerman
OzLabs, IBM Australia Development Lab

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: This is a digitally signed message part
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20060914/29c0a9dd/attachment.pgp>


More information about the Linuxppc-dev mailing list