Fix interrupt clearing in kdump shutdown sequence
Mohan Kumar M
mohan at in.ibm.com
Tue Sep 12 22:18:21 EST 2006
Hi,
Some times HVC console on a PPC machine may have pending interrupts and
in this case kdump shutdown sequence created problem by calling
chip->end. This should be chip->eoi(). The attached patch fixes this
issue. Tested on POWER5 box.
Patch generated on 2.6.18-rc6-git4.
It will be helpful if this patch is included in 2.6.18.
Regards,
Mohan.
Call chip->eoi(irq) to clear any pending interrupt in case of kdump shutdown
sequence. chip->end(irq) does not solve this purpose.
Signed-off-by: Mohan Kumar M <mohan at in.ibm.com>
---
linux-2.6.18-rc6-git4/arch/powerpc/kernel/crash.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
diff -puN linux-2.6.18-rc6-git4/arch/powerpc/kernel/crash.c~kdump-irq-fix linux-2.6.18-rc6-git4/arch/powerpc/kernel/crash.c
--- kernel/linux-2.6.18-rc6-git4/arch/powerpc/kernel/crash.c~kdump-irq-fix 2006-09-12 17:20:39.000000000 +0530
+++ kernel-mohan/linux-2.6.18-rc6-git4/arch/powerpc/kernel/crash.c 2006-09-12 17:20:51.000000000 +0530
@@ -295,7 +295,7 @@ void default_machine_crash_shutdown(stru
struct irq_desc *desc = irq_desc + irq;
if (desc->status & IRQ_INPROGRESS)
- desc->chip->end(irq);
+ desc->chip->eoi(irq);
if (!(desc->status & IRQ_DISABLED))
desc->chip->disable(irq);
_
More information about the Linuxppc-dev
mailing list