[PATCH] Make lparcfg.c work when both iseries and pseries are selected
Nathan Lynch
ntl at pobox.com
Wed Jun 28 17:29:28 EST 2006
Stephen Rothwell wrote:
> Hi Nathan,
>
> On Tue, 27 Jun 2006 23:05:40 -0500 Nathan Lynch <ntl at pobox.com> wrote:
> >
> > Stephen Rothwell wrote:
> > > static ssize_t lparcfg_write(struct file *file, const char __user * buf,
> > > size_t count, loff_t * off)
> > > {
> > > + ssize_t retval = -ENOMEM;
> > > +#ifdef CONFIG_PPC_PSERIES
> .
> .
> .
> > > +#endif /* CONFIG_PPC_PSERIES */
> > > return retval;
> > > }
> >
> > Erm... this is kind of gross, and will return -ENOMEM on iSeries when
> > it should really return -ENOSYS (I think).
>
> lparcfg_write will never be called on iSeries. The function just needs to
> exist to satisfy a conditional reference further down.
Okay. Well, my earlier comment regarding readability still stands,
and I think is bolstered somewhat by this explanation ;)
More information about the Linuxppc-dev
mailing list