[PATCH] Make lparcfg.c work when both iseries and pseries are selected

Stephen Rothwell sfr at canb.auug.org.au
Wed Jun 28 16:19:03 EST 2006


Hi Nathan,

On Tue, 27 Jun 2006 23:05:40 -0500 Nathan Lynch <ntl at pobox.com> wrote:
>
> Stephen Rothwell wrote:
> >  static ssize_t lparcfg_write(struct file *file, const char __user * buf,
> >  			     size_t count, loff_t * off)
> >  {
> > +	ssize_t retval = -ENOMEM;
> > +#ifdef CONFIG_PPC_PSERIES
	.
	.
	.
> > +#endif				/* CONFIG_PPC_PSERIES */
> >  	return retval;
> >  }
> 
> Erm... this is kind of gross, and will return -ENOMEM on iSeries when
> it should really return -ENOSYS (I think).

lparcfg_write will never be called on iSeries.  The function just needs to
exist to satisfy a conditional reference further down.

-- 
Cheers,
Stephen Rothwell                    sfr at canb.auug.org.au
http://www.canb.auug.org.au/~sfr/



More information about the Linuxppc-dev mailing list