[PATCH] mpic: add support for serial mode interrupts

Benjamin Herrenschmidt benh at kernel.crashing.org
Wed Jun 21 11:12:36 EST 2006


On Tue, 2006-06-20 at 00:35 +0200, Segher Boessenkool wrote:
> > Can you define some constants so others can see just what the bits  
> > mean
> > without digging up documentation, instead of just doing magic numbers?
> 
> [my favourite argument :-) ]
> 
> You'll have to read the documentation to properly understand what
> the bit patterns mean anyway.  And if you use symbolic names, you
> only add another step: hunting through header files.

Sure, that's why we should remove every symbolic constant in every
driver anywhere in the kernel right ? Sure would help.

Ben.





More information about the Linuxppc-dev mailing list