[PATCH] mpic: add support for serial mode interrupts
Segher Boessenkool
segher at kernel.crashing.org
Tue Jun 20 08:35:26 EST 2006
> Can you define some constants so others can see just what the bits
> mean
> without digging up documentation, instead of just doing magic numbers?
[my favourite argument :-) ]
You'll have to read the documentation to properly understand what
the bit patterns mean anyway. And if you use symbolic names, you
only add another step: hunting through header files.
> MPIC_GREG_GLOBAL_CONF_0 already does so; you can copy the style from
> there.
...but yeah, definitely, mixing styles is at least as bad.
Segher
More information about the Linuxppc-dev
mailing list