pmac_ide_init_hwif_ports duplicate

[Joseph P. Garcia]

pmac_ide_init_hwif_ports exists in two forms in the latest benh kernel.  a generic coding in pmac_setup.c for pci chips (pcmcia iirc), and a coding in ide-pmac.c for pmac specific applications.  On boot, the ide-pmac.c coding is used, but since the pmac_setup.c coding is used in the ppc function structure setup, the pmac_setup.c code is used everywhere else.  One consequence is that mediabays are no longer hot swappable.

I wonder if the pmac_setup.c coding is needed.  If it is, where?  If the only places that need the ide-pmac.c coding are ide-pmac.c and mediabay.c, then the attached patch should be a good fix.  It works by explicitly calling the ide-pmac.c coding, then calling ide_register_hw instead of ide_register.  The more generic pmac_setup.c coding is left as default for any other hot swappable ata subsystem.

Is this code going in the correct direction?  (ide_register is kinda hinted as being legacy)

Thanks.

--
Joseph P. Garcia
http://www.lycestra.com/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pmac_cdbay.patch
Type: application/octet-stream
Size: 1978 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20010827/bbd37e7c/attachment.obj>