bug in arch/ppc/mm/init.c

[Paul Mackerras]

Loic Prylli <Loic.Prylli at ens-lyon.fr> wrote:

> The init function of some drivers use ioremap, which may call
> MMU_get_page (if the target zone cross a 4Mbyte/s bounday(. But
> MMU_get_page is marked as an initfunc, so it is no longer
> present->panic.

You're right, MMU_get_page shouldn't be an initfunc.

> Here one possible solution:
> 
> --- arch/ppc/mm/init.c~ Thu Jan  7 21:06:57 1999
> +++ arch/ppc/mm/init.c  Sat Jan 30 16:01:17 1999
> @@ -883,7 +883,7 @@
>         }           
>  }
>  
> -__initfunc(static void *MMU_get_page(void))
> +static void *MMU_get_page(void)
>  {
>         void *p;
>  

Looks good to me.

Paul.

[[ This message was sent via the linuxppc-dev mailing list. Replies are ]]
[[ not forced back to the list, so be sure to  Cc linuxppc-dev  if your ]]
[[ reply is of general interest. To unsubscribe from linuxppc-dev, send ]]
[[ the message 'unsubscribe' to linuxppc-dev-request at lists.linuxppc.org ]]