[PATCH 4/7] erofs-utils: tests: fix distcheck

胡玮文 sehuww at mail.scut.edu.cn
Fri Jan 22 12:09:23 AEDT 2021

> 在 2021年1月22日,08:16,Gao Xiang <hsiangkao at redhat.com> 写道:
> Hi Weiwen,
>> On Fri, Jan 22, 2021 at 12:37:12AM +0800, Hu Weiwen wrote:
>> To get required files to final .tar.gz distribution:
>> * Any header files should goes into _SOURCES.
> should we use noinst_HEADERS instead? do you have some reference
> link (I mean document) for this? what's the impact of this,
> just dictcheck? I'm not familiar with that...


I quote from above link:

Header files listed in a _SOURCES definition will be included in the distribution but otherwise ignored

>> * check scripts should goes into dist_check_SCRIPTS.
>> * 001.out will trigger a GNU make implicit rule, rename it to 001-out
> How about also renaming $tmp.out to $tmp.stdout?

Yes, that should work.

> Also, 'since experimental-tests' has't merged into dev, do you mind
> me folding these bugfix patches (I mean except for "[PATCH 5/7] and
> [PATCH 7/7]") into the original patches, and add your contribution
> description & SOB(Signed-off-by:) to the commit message? That would
> make the whole commit history much cleaner... If you agree that, I
> will resend the testcase patchset later with your fixes and new
> patches and wait for Guifu to review if he has extra free slots.


> Note that, only dev & master branches have stable commit ids.
> experimental-xxx could be rebased frequently.
> Thanks,
> Gao Xiang
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ozlabs.org/pipermail/linux-erofs/attachments/20210122/baeb8ac4/attachment.htm>

More information about the Linux-erofs mailing list