[PATCH 4/7] erofs-utils: tests: fix distcheck

Gao Xiang hsiangkao at redhat.com
Fri Jan 22 11:16:05 AEDT 2021

Hi Weiwen,

On Fri, Jan 22, 2021 at 12:37:12AM +0800, Hu Weiwen wrote:
> To get required files to final .tar.gz distribution:
> * Any header files should goes into _SOURCES.

should we use noinst_HEADERS instead? do you have some reference
link (I mean document) for this? what's the impact of this,
just dictcheck? I'm not familiar with that...

> * check scripts should goes into dist_check_SCRIPTS.
> * 001.out will trigger a GNU make implicit rule, rename it to 001-out

How about also renaming $tmp.out to $tmp.stdout?

Also, 'since experimental-tests' has't merged into dev, do you mind
me folding these bugfix patches (I mean except for "[PATCH 5/7] and
[PATCH 7/7]") into the original patches, and add your contribution
description & SOB(Signed-off-by:) to the commit message? That would
make the whole commit history much cleaner... If you agree that, I
will resend the testcase patchset later with your fixes and new
patches and wait for Guifu to review if he has extra free slots.

Note that, only dev & master branches have stable commit ids.
experimental-xxx could be rebased frequently.

Gao Xiang

More information about the Linux-erofs mailing list