[PATCH v1 1/8] ARM: dts: aspeed: system1: Add IPMB device

[Ninad Palsule]

Hello Krzysztof,

Thanks for the review. Sorry for the delay as I was on vacation.

On 12/13/24 09:48, Krzysztof Kozlowski wrote:
> On 13/12/2024 15:50, Ninad Palsule wrote:
>> From: NINAD PALSULE<ninadpalsule at us.ibm.com>
>>
>> Add IPMB device sitting behind PCH module
>>
>> Signed-off-by: Ninad Palsule<ninad at linux.ibm.com>
>> ---
>>   arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts | 10 ++++++++++
>>   1 file changed, 10 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts
>> index 8f77bc9e860c..51a116d7041a 100644
>> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts
>> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts
>> @@ -763,6 +763,16 @@ i2c3mux0chn7: i2c at 7 {
>>   
>>   &i2c4 {
>>   	status = "okay";
>> +	multi-master;
>> +	bus-frequency = <1000000>;
>> +
>> +	//Set bmc' slave address;
> Is this relevant/useful comment? Why is it even here?
Yes, Removed the comment.
>
>> +	bmc_slave at 10 {
> Node names should be generic. See also an explanation and list of
> examples (not exhaustive) in DT specification:
> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
>
> Also: use DTS coding style (there are no underscores in node names) and
> use preferred naming scheme (see general kernel coding style / naming).

Changed the name to generic node name.

Regards,

Ninad

>
>
>
> Best regards,
> Krzysztof
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ozlabs.org/pipermail/linux-aspeed/attachments/20250107/5d5df073/attachment.htm>