[PATCH v1 3/8] ARM: dts: aspeed: system1: Add RGMII support

[Ninad Palsule]

Hi Andrew,

Thank you for the review. Sorry for the late reply as I was on vacation.

On 12/13/24 16:03, Andrew Lunn wrote:
>> +&mac0 {
>> +	status = "okay";
>> +
>> +	phy-mode = "rgmii-rxid";
> Why is everybody getting RGMII wrong this week?
>
> Do you have an extra long clock line on the PCB for the TX clock?

We are using ASPEED ast2600 chip and their recommendation is to enable 
RX interface delay from the PHY chip for mac0 and mac1.

We tested the network and it is working as expected.

>
>> +	phy-handle = <&ethphy0>;
>> +
>> +	pinctrl-names = "default";
>> +	pinctrl-0 = <&pinctrl_rgmii1_default>;
>> +};
>> +
>>   &mac2 {
>>   	status = "okay";
>> +
>> +	phy-mode = "rgmii";
> Do you have extra long clock lines on the PCB for both Rx and Tx
> clock?
>
> I suspect you don't and the RGMII delays are messed up somehow.

This is a recommendation by ASPEED for mac2 and mac3. We tested the 
network and it is working as expected.

Can you please let me know more about your concern?

Regards,

Ninad

>
> 	Andrew
>