<!DOCTYPE html>
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p>Hello <span style="white-space: pre-wrap">Krzysztof,</span></p>
<p><span style="white-space: pre-wrap">Thanks for the review. Sorry for the delay as I was on vacation.
</span></p>
<div class="moz-cite-prefix">On 12/13/24 09:48, Krzysztof Kozlowski
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:45b55b4b-25e4-4e8b-8c95-8c3129e72227@kernel.org">
<pre wrap="" class="moz-quote-pre">On 13/12/2024 15:50, Ninad Palsule wrote:
</pre>
<blockquote type="cite">
<pre wrap="" class="moz-quote-pre">From: NINAD PALSULE <a class="moz-txt-link-rfc2396E" href="mailto:ninadpalsule@us.ibm.com"><ninadpalsule@us.ibm.com></a>
Add IPMB device sitting behind PCH module
Signed-off-by: Ninad Palsule <a class="moz-txt-link-rfc2396E" href="mailto:ninad@linux.ibm.com"><ninad@linux.ibm.com></a>
---
arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts
index 8f77bc9e860c..51a116d7041a 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts
+++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts
@@ -763,6 +763,16 @@ i2c3mux0chn7: i2c@7 {
&i2c4 {
status = "okay";
+ multi-master;
+ bus-frequency = <1000000>;
+
+ //Set bmc' slave address;
</pre>
</blockquote>
<pre wrap="" class="moz-quote-pre">
Is this relevant/useful comment? Why is it even here?</pre>
</blockquote>
Yes, Removed the comment.<br>
<blockquote type="cite"
cite="mid:45b55b4b-25e4-4e8b-8c95-8c3129e72227@kernel.org">
<pre wrap="" class="moz-quote-pre">
</pre>
<blockquote type="cite">
<pre wrap="" class="moz-quote-pre">+ bmc_slave@10 {
</pre>
</blockquote>
<pre wrap="" class="moz-quote-pre">
Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
<a class="moz-txt-link-freetext" href="https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation">https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation</a>
Also: use DTS coding style (there are no underscores in node names) and
use preferred naming scheme (see general kernel coding style / naming).</pre>
</blockquote>
<p>Changed the name to generic node name.</p>
<p>Regards,</p>
<p>Ninad<br>
</p>
<blockquote type="cite"
cite="mid:45b55b4b-25e4-4e8b-8c95-8c3129e72227@kernel.org">
<pre wrap="" class="moz-quote-pre">
Best regards,
Krzysztof
</pre>
</blockquote>
</body>
</html>