[PATCH 1/3] usb: aspeed-vhub: add qualifier descriptor
Benjamin Herrenschmidt
benh at kernel.crashing.org
Tue Nov 30 10:40:59 AEDT 2021
On Fri, 2021-11-26 at 19:09 +0800, Neal Liu wrote:
>
> @@ -417,10 +435,9 @@ enum std_req_rc ast_vhub_std_hub_request(struct ast_vhub_ep *ep,
>
> /* GET/SET_CONFIGURATION */
> case DeviceRequest | USB_REQ_GET_CONFIGURATION:
> - return ast_vhub_simple_reply(ep, 1);
> + return ast_vhub_simple_reply(ep, vhub->current_config);
> case DeviceOutRequest | USB_REQ_SET_CONFIGURATION:
> - if (wValue != 1)
> - return std_req_stall;
> + vhub->current_config = wValue;
> return std_req_complete;
This is odd.. why should we support arbitrary SET_CONFIGURATION for
configs we don't support ?
Otherwise looks good.
Cheers,
Ben.
More information about the Linux-aspeed
mailing list