[PATCH 1/3] usb: aspeed-vhub: add qualifier descriptor
Neal Liu
neal_liu at aspeedtech.com
Tue Nov 30 20:30:48 AEDT 2021
> -----Original Message-----
> From: Benjamin Herrenschmidt <benh at kernel.crashing.org>
> Sent: Tuesday, November 30, 2021 7:41 AM
> To: Neal Liu <neal_liu at aspeedtech.com>; Felipe Balbi <balbi at kernel.org>;
> Greg Kroah-Hartman <gregkh at linuxfoundation.org>; Joel Stanley
> <joel at jms.id.au>; Andrew Jeffery <andrew at aj.id.au>; Cai Huoqing
> <caihuoqing at baidu.com>; Tao Ren <rentao.bupt at gmail.com>; Julia Lawall
> <julia.lawall at inria.fr>; kernel test robot <lkp at intel.com>; Sasha Levin
> <sashal at kernel.org>; linux-usb at vger.kernel.org; linux-kernel at vger.kernel.org;
> linux-arm-kernel at lists.infradead.org; linux-aspeed at lists.ozlabs.org
> Cc: BMC-SW <BMC-SW at aspeedtech.com>
> Subject: Re: [PATCH 1/3] usb: aspeed-vhub: add qualifier descriptor
>
> On Fri, 2021-11-26 at 19:09 +0800, Neal Liu wrote:
> >
> > @@ -417,10 +435,9 @@ enum std_req_rc ast_vhub_std_hub_request(struct
> > ast_vhub_ep *ep,
> >
> > /* GET/SET_CONFIGURATION */
> > case DeviceRequest | USB_REQ_GET_CONFIGURATION:
> > - return ast_vhub_simple_reply(ep, 1);
> > + return ast_vhub_simple_reply(ep, vhub->current_config);
> > case DeviceOutRequest | USB_REQ_SET_CONFIGURATION:
> > - if (wValue != 1)
> > - return std_req_stall;
> > + vhub->current_config = wValue;
> > return std_req_complete;
>
> This is odd.. why should we support arbitrary SET_CONFIGURATION for configs
> we don't support ?
>
> Otherwise looks good.
>
> Cheers,
> Ben.
>
This is unnecessary...
I'll remove it in next patch.
Thanks
-Neal
More information about the Linux-aspeed
mailing list