[PATCH 2/2] ARM: imx6q: replace clk_register_clkdev with clock DT lookup
Shawn Guo
shawn.guo at linaro.org
Wed Aug 22 12:47:09 EST 2012
On Mon, Aug 20, 2012 at 12:22:56PM -0500, Matt Sealey wrote:
> It's not bloat just because it is by its very definition "a big list", is it?
>
Grep for_each_node_by_*() and for_each_*_node() (include/linux/of.h)
in the tree to see how often these global device tree searching is
used, you may know how important not having so many nodes is.
> How do you explain duplicating the clock names in the array AND in the
> device node as NOT being bloated?
>
> You're going to have to define these clocks as a tree with parents and
> leaf nodes anyway in the clock subsystem. Why not define these in the
> device tree in total and reference them by handle when you build the
> entire clock tree from the ground up? Or will it just be all the
> clocks defined in Linux, but the lookups (which is what I see here)
> moved into the DT? Why not form the lookups as part of the definition
> of the clock tree?
>
This is something I had tried long time before, but it did not get
accepted because:
* It's unnecessary to encode the entire clock tree which is SoC
specific in device tree. Clock driver is a good place for that.
* Again, doing so will bloat device tree with hundreds of nodes.
--
Regards,
Shawn
More information about the devicetree-discuss
mailing list